Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/4] vmscan: make lru_index() helper function | Date | Fri, 27 Nov 2009 14:47:59 +0900 (JST) |
| |
> > @@ -1373,10 +1378,8 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, > > */ > > reclaim_stat->recent_rotated[file] += nr_rotated; > > > > - move_active_pages_to_lru(zone, &l_active, > > - LRU_ACTIVE + file * LRU_FILE); > > - move_active_pages_to_lru(zone, &l_inactive, > > - LRU_BASE + file * LRU_FILE); > > + move_active_pages_to_lru(zone, &l_active, lru_index(1, file)); > > + move_active_pages_to_lru(zone, &l_inactive, lru_index(0, file)); > > How about: > move_active_pages_to_lru(zone, &l_active, lru_index(LRU_ACTIVE, file)); > move_active_pages_to_lru(zone, &l_inactive, lru_index(LRU_BASE, file)); > ?
No. lru_index mean convert two boolean to one index. it shoudn't be passed lru index itself.
| |