[lkml]   [2009]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 7/7] kfifo: add record handling functions
On Thu, Nov 26, 2009 at 05:07:12PM +0100, Stefani Seibold wrote:
> I analyzed the code and most of them will be optimized away by the
> compiler. The reason for this design decision was that i want no
> performance regression against the old kfifo implementation.
> But if the majority vote for an non inline version i will do it. It will
> make the code more readable and slim down the footprint.

I vote for smaller text size if possible. I doubt kfifo is used in any
circumstances where a function call or two is a big problem. But of course
some inlines might be smaller than calls.

But then this code has been pending for a long time and I
have some potential users. It would be good to merge ASAP and do such tweaks
later in tree.


-- -- Speaking for myself only.

 \ /
  Last update: 2009-11-26 17:47    [W:0.057 / U:12.352 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site