Messages in this thread | | | Date | Thu, 26 Nov 2009 17:44:14 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 7/7] kfifo: add record handling functions |
| |
On Thu, Nov 26, 2009 at 05:07:12PM +0100, Stefani Seibold wrote: > I analyzed the code and most of them will be optimized away by the > compiler. The reason for this design decision was that i want no > performance regression against the old kfifo implementation. > > But if the majority vote for an non inline version i will do it. It will > make the code more readable and slim down the footprint.
I vote for smaller text size if possible. I doubt kfifo is used in any circumstances where a function call or two is a big problem. But of course some inlines might be smaller than calls.
But then this code has been pending for a long time and I have some potential users. It would be good to merge ASAP and do such tweaks later in tree.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |