Messages in this thread | | | Date | Wed, 25 Nov 2009 11:35:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Port ricoh_mmc from driver to pci quirk. |
| |
On Wed, 25 Nov 2009 08:53:24 -0800 Philip Langdale <philipl@overt.org> wrote:
> On Wed, 25 Nov 2009 16:58:41 +0200 > Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > >From 5c5e6f5ab1a5a09a430f410cab4b160a5e65501c Mon Sep 17 00:00:00 > > >2001 > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Date: Wed, 25 Nov 2009 16:37:46 +0200 > > Subject: [PATCH] Port ricoh_mmc from driver to pci quirk. > > This is much cleaner and correct solution
This patch actually fixes a bug but the changelog forgot to tell us this important fact.
> I'm fine with the concept, but when I originally started work on > Ricoh support, Pierre specifically didn't want a pci quirk. > > Pierre wrote: > > I'd rather we didn't. The current style of quirks are bad enough, > > making them even more vendor or device specific is a bit more than I'm > > willing to accept right now (seriously, how hard can it be to follow > > the damn spec?).
Can the bug be fixed by other means, within ricoh_mmc.c?
It's a bit sad to add a lump of code to everyone's kernel like this - what percentage of those machines actually have a ricoh mmc controller?
| |