lkml.org 
[lkml]   [2009]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 82/86] pata_via: clear UDMA transfer mode bit for PIO and MWDMA
    > Do you really find such tidy patch hard to review?

    When doing it at speed - yes.

    > /* Set UDMA unless device is not UDMA capable */
    > - if (udma_type && t.udma) {
    > - u8 cable80_status;
    > + if (udma_type) {
    > + u8 udma_etc;

    Ok that makes sense - we in fact could hit this case on a failure
    changedown from UDMA to PIO.


    \
     
     \ /
      Last update: 2009-11-25 19:07    [W:0.018 / U:3.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site