Messages in this thread | | | Date | Wed, 25 Nov 2009 17:00:32 +0100 | From | Ingo Molnar <> | Subject | Re: [RFC,PATCH 14/14] utrace core |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> Much better. But in this case please note that most of tracehooks just > do: > > if (unlikely(task_utrace_flags(current) & SOME_EVENT)) > utrace_report_some_event(); > > I really don't understand why we shouldn't have (trivial!) helpers for > this. (As for naming - personally I do not care at all ;)
We prefer helpers in most such cases - especially when in the normal case the helper has no side effects - as here. Then we want to compress all such reporting/callback as much as possible.
Using helpers to abstract away functionality is one of the basic elements of writing clean kernel code.
Ingo
| |