lkml.org 
[lkml]   [2009]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC,PATCH 14/14] utrace core

* Oleg Nesterov <oleg@redhat.com> wrote:

> Much better. But in this case please note that most of tracehooks just
> do:
>
> if (unlikely(task_utrace_flags(current) & SOME_EVENT))
> utrace_report_some_event();
>
> I really don't understand why we shouldn't have (trivial!) helpers for
> this. (As for naming - personally I do not care at all ;)

We prefer helpers in most such cases - especially when in the normal
case the helper has no side effects - as here. Then we want to compress
all such reporting/callback as much as possible.

Using helpers to abstract away functionality is one of the basic
elements of writing clean kernel code.

Ingo


\
 
 \ /
  Last update: 2009-11-25 17:03    [W:0.081 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site