Messages in this thread | | | Date | Wed, 25 Nov 2009 07:43:39 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 2/3] trace_kprobes: always show group name |
| |
Lai Jiangshan wrote: > > Sometimes the group name is not "kprobes", > It'll be better if we can read it from tracing/kprobe_events. > > # echo 'r:laijs/vfs_read vfs_read %ax' > kprobe_events > # cat kprobe_events > r:laijs/vfs_read vfs_read %ax=%ax
Yep, that looks very nice :-)
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
> > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > --- > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 79ce6a2..9e42f2a 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -758,7 +758,7 @@ static int probes_seq_show(struct seq_file *m, void *v) > char buf[MAX_ARGSTR_LEN + 1]; > > seq_printf(m, "%c", probe_is_return(tp) ? 'r' : 'p'); > - seq_printf(m, ":%s", tp->call.name); > + seq_printf(m, ":%s/%s", tp->call.system, tp->call.name); > > if (tp->symbol) > seq_printf(m, " %s+%u", probe_symbol(tp), tp->rp.kp.offset); > >
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |