Messages in this thread | | | Date | Mon, 23 Nov 2009 12:20:38 -0800 (PST) | Subject | Re: drivers/ide/au1xxx-ide.c: use resource_size() | From | David Miller <> |
| |
From: "H Hartley Sweeten" <hartleys@visionengravers.com> Date: Mon, 23 Nov 2009 15:01:02 -0500
> On Monday, November 23, 2009 11:38 AM, David Miller wrote: >>> >>> - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1); >>> + ahwif->regbase = (u32)ioremap(res->start, resource_size(res)); >>> if (ahwif->regbase == 0) { >>> ret = -ENOMEM; >>> goto out; >> >> That needs some fixing. ioremap()'s return value is an >> "__iomem" pointer, not an integer. ->regbase's type should be >> changed to something like "void __iomem *" etc. > > FWIW, following is an updated patch that fixes the "__iomem" pointer.
Please, I've already applied your resource_size() patch, and you should submit a seperate patch relative to that in order to address the ioremap() pointer issues.
Thank you.
| |