lkml.org 
[lkml]   [2009]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] twl4030-regulator: Remove regulator from all groups when disabling
Hello Liam,

On Fri, Nov 20, 2009 at 08:07:59PM +0100, ext Liam Girdwood wrote:
> On Fri, 2009-11-20 at 18:29 +0200, Eduardo Valentin wrote:
> > Just remove regulator from all groups when disabling. This way we
> > avoid problems if boot loader touches twl4030 registers.
> >
> > Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> > ---
> > drivers/regulator/twl4030-regulator.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
> > index e2032fb..27b3115 100644
> > --- a/drivers/regulator/twl4030-regulator.c
> > +++ b/drivers/regulator/twl4030-regulator.c
> > @@ -126,7 +126,7 @@ static int twl4030reg_disable(struct regulator_dev *rdev)
> > if (grp < 0)
> > return grp;
> >
> > - grp &= ~P1_GRP;
> > + grp &= ~(P1_GRP & P2_GRP | P3_GRP);
> > return twl4030reg_write(info, VREG_GRP, grp);
> > }
> >
>
> Applied.

Thanks for applying. But this one has actually a typo
It was supposed to be:

+ grp &= ~(P1_GRP | P2_GRP | P3_GRP);

Could you please apply this one instead:
http://lkml.org/lkml/2009/11/20/231

?

>
> Thanks
>
> Liam
>


BR,

--
Eduardo Valentin


\
 
 \ /
  Last update: 2009-11-23 08:11    [W:0.655 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site