Messages in this thread |  | | Date | Sat, 21 Nov 2009 14:35:04 -0200 | | From | Arnaldo Carvalho de Melo <> | | Subject | Re: [PATCH 1/3] perf symbols: fixup kernel_maps__fixup_end end map |
| |
Em Sat, Nov 21, 2009 at 02:31:24PM -0200, Arnaldo Carvalho de Melo escreveu: > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > We better call this routine after both the kernel and modules are > loaded, because as it was if there weren't modules it would be called,
s/would/would not/g
Ingo, if you see this before merging, please ammend the above comment line :)
> resulting in kernel_map->end remaining at zero, so no map would be found > and consequently the kernel symtab wouldn't get loaded, i.e. no kernel > symbols would be resolved. > > Also this fixes another case, that is when we _have_ modules, but the > last map would have its ->end address not set before we loaded its > symbols, which would never happen because ->end was not set.
|  |