Messages in this thread Patch in this message | | | Date | Fri, 20 Nov 2009 20:19:10 +0100 | Subject | [PATCH] net: ETHOC should depend on HAS_DMA (was: Re: [PATCH] ETHOC: fix build breakage on s390) | From | Geert Uytterhoeven <> |
| |
On Mon, Mar 30, 2009 at 10:30, Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > Let driver depend on HAS_IOMEM to avoid build breakage on s390: > > CC drivers/net/ethoc.o > drivers/net/ethoc.c: In function 'ethoc_read': > drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32' > drivers/net/ethoc.c: In function 'ethoc_write': > drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32' > drivers/net/ethoc.c: In function 'ethoc_rx': > drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio' > drivers/net/ethoc.c: In function 'ethoc_start_xmit': > drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio' > > Cc: Thierry Reding <thierry.reding@avionic-design.de> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/net/Kconfig > =================================================================== > --- linux-2.6.orig/drivers/net/Kconfig > +++ linux-2.6/drivers/net/Kconfig > @@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY > > config ETHOC > tristate "OpenCores 10/100 Mbps Ethernet MAC support" > - depends on NET_ETHERNET > + depends on NET_ETHERNET && HAS_IOMEM
This is not sufficient, it has to depend on HAS_DMA, too:
From cdb6fc81662e9afd6019221acc7f56d2d7dcd161 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Fri, 20 Nov 2009 20:07:09 +0100 Subject: [PATCH] net: ETHOC should depend on HAS_DMA
When building for Sun 3:
drivers/net/ethoc.c:1091: undefined reference to `dma_free_coherent' drivers/built-in.o: In function `ethoc_probe': drivers/net/ethoc.c:965: undefined reference to `dma_alloc_coherent' drivers/net/ethoc.c:1063: undefined reference to `dma_free_coherent'
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 8015ecc..9e7c76e 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -993,7 +993,7 @@ config ENC28J60_WRITEVERIFY
config ETHOC tristate "OpenCores 10/100 Mbps Ethernet MAC support" - depends on NET_ETHERNET && HAS_IOMEM + depends on NET_ETHERNET && HAS_IOMEM && HAS_DMA select MII select PHYLIB select CRC32 -- 1.6.0.4 Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |