Messages in this thread | | | Date | Mon, 2 Nov 2009 22:26:33 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes |
| |
On Mon, Nov 02, 2009 at 04:16:25PM -0500, Masami Hiramatsu wrote: > Masami Hiramatsu wrote: >> Ingo Molnar wrote: >>> What we want here is two fold: >>> >>> - enable kprobes event support when perf events is enabled and kprobes >>> is enabled. We dont want another config option for it. >> >> Sure, at least that combination should enable kprobe-tracer forcibly. > > Hmm, someone may not want to enables kprobe-tracer. Perhaps, > "default y if (EVENT_PROFILE)" is enough, isn't it? >
I guess it should be sufficient yeah. We want to strongly recommend the kprobe events if we have enabled perf, but we don't want to force it.
Also in this case we need a verbose runtime report of the lack of this tracer in debugfs from perf probe if needed.
| |