Messages in this thread | | | Date | Mon, 2 Nov 2009 17:46:21 +0100 | From | Andreas Herrmann <> | Subject | Re: [ RFC, PATCH - 1/2 ] x86-microcode: refactor microcode output messages |
| |
On Sun, Nov 01, 2009 at 11:22:59PM +0100, dimm wrote: > > Hi, > > > this is in response to Mike's patch "Limit the number of microcode > messages". > > What's about the following (yet preliminary and not thoroughly tested) > approach?
Hmm, patch-1 doesn't apply:
patching file arch/x86/include/asm/microcode.h patching file arch/x86/kernel/microcode_amd.c Hunk #1 succeeded at 152 (offset -4 lines). Hunk #2 succeeded at 240 (offset -7 lines). patch: **** malformed patch at line 99: size_t size)
> patch-1: > > simplify 'struct ucode_cpu_info' and related operational logic. > > > patch-2: > > reduce a number of similar 'microcode version' messages by printing a > single message for all cpus with equal microcode version, like:
Would be useful on systems with many cores.
On AMD multi-socket systems often you have the same CPU revisions and thus you'd like to have similar ucode on all cores. Hence there is a high chance that your code would reduce the amount of microcode log messages during boot.
I'd like to test it but would need patches that do apply ...
Thanks, Andreas
| |