Messages in this thread | | | Date | Mon, 2 Nov 2009 14:09:25 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] mfd/mc13783: near complete rewrite |
| |
On Mon, Nov 02, 2009 at 02:58:27PM +0100, Uwe Kleine-K?nig wrote: > On Mon, Nov 02, 2009 at 11:51:01AM +0000, Mark Brown wrote:
> > This might create issues with a request_nounmask() function, though a > > request plus mask is probably enough - I guess you're using this for > > your the RTC driver in which case a spurious periodic interrupt is > > unlikely to be an issue.
> Yes, I use it to simplify things in the RTC driver a bit. I register > the 1HZ irq unconditionally and only track if it's masked or not. This way > I can save some case discrimination.
What I've done for wm8350 is just request the IRQ then immediately mask it and not worry about a periodic notification coming in in the gap - reporting the extra periodic notification is vanishingly unlikely to do any harm in the case that the race does crop up.
| |