lkml.org 
[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/27] BKL: Remove BKL from efs
    Acked-by: Coly Li <coly.li@suse.de>

    On 2009年11月02日 18:04, Jan Blunck Wrote:
    > BKL is only used in fill_super. It is safe to remove it.
    >
    > Signed-off-by: Jan Blunck <jblunck@suse.de>
    > ---
    > fs/efs/super.c | 10 ++--------
    > 1 files changed, 2 insertions(+), 8 deletions(-)
    >
    > diff --git a/fs/efs/super.c b/fs/efs/super.c
    > index 0981141..f049428 100644
    > --- a/fs/efs/super.c
    > +++ b/fs/efs/super.c
    > @@ -249,13 +249,9 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
    > struct inode *root;
    > int ret = -EINVAL;
    >
    > - lock_kernel();
    > -
    > - sb = kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL);
    > - if (!sb) {
    > - unlock_kernel();
    > + sb = kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL);
    > + if (!sb)
    > return -ENOMEM;
    > - }
    > s->s_fs_info = sb;
    >
    > s->s_magic = EFS_SUPER_MAGIC;
    > @@ -323,14 +319,12 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
    > goto out_no_fs;
    > }
    >
    > - unlock_kernel();
    > return 0;
    >
    > out_no_fs_ul:
    > out_no_fs:
    > s->s_fs_info = NULL;
    > kfree(sb);
    > - unlock_kernel();
    > return ret;
    > }
    >

    --
    Coly Li
    SuSE Labs
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-02 11:43    [W:0.022 / U:0.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site