lkml.org 
[lkml]   [2009]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/20] BKL: Remove BKL from ext3_put_super() and ext3_remount()
    Date
    The BKL lock is protecting the remounting against a potential call to
    ext3_put_super(). This could not happen, since this is protected by the
    s_umount rw semaphore of struct super_block.

    Therefore I think the BKL is protecting nothing here.

    Signed-off-by: Jan Blunck <jblunck@suse.de>
    Acked-by: Jan Kara <jack@suse.cz>
    ---
    fs/ext3/super.c | 8 --------
    1 files changed, 0 insertions(+), 8 deletions(-)

    diff --git a/fs/ext3/super.c b/fs/ext3/super.c
    index 373fc54..d02fbc6 100644
    --- a/fs/ext3/super.c
    +++ b/fs/ext3/super.c
    @@ -398,8 +398,6 @@ static void ext3_put_super (struct super_block * sb)
    struct ext3_super_block *es = sbi->s_es;
    int i, err;

    - lock_kernel();
    -
    ext3_xattr_put_super(sb);
    err = journal_destroy(sbi->s_journal);
    sbi->s_journal = NULL;
    @@ -448,8 +446,6 @@ static void ext3_put_super (struct super_block * sb)
    sb->s_fs_info = NULL;
    kfree(sbi->s_blockgroup_lock);
    kfree(sbi);
    -
    - unlock_kernel();
    }

    static struct kmem_cache *ext3_inode_cachep;
    @@ -2497,8 +2493,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
    int i;
    #endif

    - lock_kernel();
    -
    /* Store the original options */
    lock_super(sb);
    old_sb_flags = sb->s_flags;
    @@ -2609,7 +2603,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
    kfree(old_opts.s_qf_names[i]);
    #endif
    unlock_super(sb);
    - unlock_kernel();
    return 0;
    restore_opts:
    sb->s_flags = old_sb_flags;
    @@ -2627,7 +2620,6 @@ restore_opts:
    }
    #endif
    unlock_super(sb);
    - unlock_kernel();
    return err;
    }

    --
    1.6.4.2


    \
     
     \ /
      Last update: 2009-11-18 10:33    [W:4.281 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site