Messages in this thread | | | Date | Tue, 17 Nov 2009 21:29:34 -0800 | From | Darren Hart <> | Subject | Re: [PATCH] futex: add FUTEX_SET_WAIT operation |
| |
Michel Lespinasse wrote: > On Tue, Nov 17, 2009 at 08:16:06AM -0800, Darren Hart wrote: >>> Darren has recently been putting a lot of effort in making a futex test >>> suite: >>> >>> http://git.kernel.org/?p=linux/kernel/git/dvhart/futextest.git >>> >>> Its not yet complete, but hopefully it will soon be :-) >> Michael, would you be willing to include a version of this test in the >> above test suite? If so, then in keeping with the rest of the test suite, >> I would recommend splitting into two tests, one of each opcode being >> tested, and add argument to define thread count. The run.sh script would >> then run each thread count as a separate test run. > > I had a quick look at the tree (using the http interface). I sure would not > mind adding the tests, and the futextest.h file would make them look > quite cleaner than my previous version. Just to be sure, would you put them > under performance/ or stress/ ? This would be the first test to be added > in these directories in any case, right ? (just asking in case I missed > something obvious).
Michel, excellent!
I think performance sounds like the right place to me. Performance is where I plan to put measurement tests where you report some score. Stress tests are considered to have passed if the run to completion without locking up or crashing the kernel :-)
We should take a look at the perf tool to see what requirements it may impose on tests we want to share between perf and futextest.
-- Darren Hart IBM Linux Technology Center Real-Time Linux Team
| |