Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() | Date | Wed, 18 Nov 2009 18:35:54 +0100 |
| |
Am Mittwoch, 18. November 2009 18:27:30 schrieb Jamie Lokier: > > No. Your logic is flawed > > > > The BKL is protected something here - it protects the change of offset > > with respect to other BKL users within drivers. The question is what if > > anything in any other driver code depends upon the BKL and uses it to > > protect f_pos. Probably very little if anything but a grep for f_pos > > through the drivers might not be a bad idea before assuming this. Very > > few touch f_pos except in their own llseek method. > > Of course, drivers shouldn't be using f_pos outside their llseek > method, as they should all behave the same with pread/pwrite as with > llseek+read/write.
Might not a driver update f_pos after read/write?
Regards Oliver
| |