lkml.org 
[lkml]   [2009]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] macvlan: export macvlan mode through netlink
    Arnd Bergmann a écrit :
    > In order to support all three modes of macvlan at
    > runtime, extend the existing netlink protocol
    > to allow choosing the mode per macvlan slave
    > interface.
    >
    > This depends on a matching patch to iproute2
    > in order to become accessible in user land.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > ---
    > drivers/net/macvlan.c | 67 +++++++++++++++++++++++++++++++++++++++++-----
    > include/linux/if_link.h | 15 ++++++++++
    > 2 files changed, 74 insertions(+), 8 deletions(-)
    >
    > diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
    > index fa8b568..731017e 100644
    > --- a/drivers/net/macvlan.c
    > +++ b/drivers/net/macvlan.c
    > @@ -33,12 +33,6 @@
    >
    > #define MACVLAN_HASH_SIZE (1 << BITS_PER_BYTE)
    >
    > -enum macvlan_type {
    > - MACVLAN_PRIVATE = 1,
    > - MACVLAN_VEPA = 2,
    > - MACVLAN_BRIDGE = 4,
    > -};

    I realize you defined MACVLAN_PRIVATE in patch 2, but used MACVLAN_MODE_PRIVATE,
    so patch 2 is not compilable and breaks bisection ?


    > +
    > +enum ifla_macvlan_mode {
    > + MACVLAN_MODE_PRIVATE = 1, /* don't talk to other macvlans */
    > + MACVLAN_MODE_VEPA = 2, /* talk to other ports through ext bridge */
    > + MACVLAN_MODE_BRIDGE = 4, /* talk to bridge ports directly */
    > +};
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-18 07:51    [W:0.021 / U:1.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site