lkml.org 
[lkml]   [2009]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] mtd: fix mtd_blkdevs problem with caches on some architectures (2.6.31)
    	Mtdblock driver doesn't call flush_dcache_page for pages in request.
    This may cause problem on architectures where icache doesn't fill from
    dcache or with dcache aliases.
    This patch resolves this issue.

    Signed-off-by: Ilya Loginov <isloginov@gmail.com>
    ---
    mtd_blkdevs.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
    index 7baba40..59d5d25 100644
    --- a/drivers/mtd/mtd_blkdevs.c
    +++ b/drivers/mtd/mtd_blkdevs.c
    @@ -46,6 +46,8 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr,
    {
    unsigned long block, nsect;
    char *buf;
    + struct req_iterator iter;
    + struct bio_vec *bvec;

    block = blk_rq_pos(req) << 9 >> tr->blkshift;
    nsect = blk_rq_cur_bytes(req) >> tr->blkshift;
    @@ -68,12 +70,17 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr,
    for (; nsect > 0; nsect--, block++, buf += tr->blksize)
    if (tr->readsect(dev, block, buf))
    return -EIO;
    + rq_for_each_segment(bvec, req, iter)
    + flush_dcache_page(bvec->bv_page);
    return 0;

    case WRITE:
    if (!tr->writesect)
    return -EIO;

    + rq_for_each_segment(bvec, req, iter)
    + flush_dcache_page(bvec->bv_page);
    +
    for (; nsect > 0; nsect--, block++, buf += tr->blksize)
    if (tr->writesect(dev, block, buf))
    return -EIO;

    \
     
     \ /
      Last update: 2009-11-18 15:07    [W:0.023 / U:1.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site