lkml.org 
[lkml]   [2009]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/7] Revert "Intel IOMMU: Avoid memory allocation failures in dma map api calls"
    Date

    commit eb3fa7cb51 said Intel IOMMU

    Intel IOMMU driver needs memory during DMA map calls to setup its
    internal page tables and for other data structures. As we all know
    that these DMA map calls are mostly called in the interrupt context
    or with the spinlock held by the upper level drivers(network/storage
    drivers), so in order to avoid any memory allocation failure due to
    low memory issues, this patch makes memory allocation by temporarily
    setting PF_MEMALLOC flags for the current task before making memory
    allocation calls.

    We evaluated mempools as a backup when kmem_cache_alloc() fails
    and found that mempools are really not useful here because
    1) We don't know for sure how much to reserve in advance
    2) And mempools are not useful for GFP_ATOMIC case (as we call
    memory alloc functions with GFP_ATOMIC)

    (akpm: point 2 is wrong...)

    The above description doesn't justify to waste system emergency memory
    at all. Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need
    few memory, anyone must not prevent it. Otherwise the system cause
    mysterious hang-up and/or OOM Killer invokation.

    Plus, akpm already pointed out what we should do.

    Then, this patch revert it.

    Cc: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Cc: iommu@lists.linux-foundation.org
    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    drivers/pci/intel-iommu.c | 30 ++++--------------------------
    1 files changed, 4 insertions(+), 26 deletions(-)

    diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
    index 1840a05..17d6f1e 100644
    --- a/drivers/pci/intel-iommu.c
    +++ b/drivers/pci/intel-iommu.c
    @@ -386,31 +386,9 @@ static struct kmem_cache *iommu_domain_cache;
    static struct kmem_cache *iommu_devinfo_cache;
    static struct kmem_cache *iommu_iova_cache;

    -static inline void *iommu_kmem_cache_alloc(struct kmem_cache *cachep)
    -{
    - unsigned int flags;
    - void *vaddr;
    -
    - /* trying to avoid low memory issues */
    - flags = current->flags & PF_MEMALLOC;
    - current->flags |= PF_MEMALLOC;
    - vaddr = kmem_cache_alloc(cachep, GFP_ATOMIC);
    - current->flags &= (~PF_MEMALLOC | flags);
    - return vaddr;
    -}
    -
    -
    static inline void *alloc_pgtable_page(void)
    {
    - unsigned int flags;
    - void *vaddr;
    -
    - /* trying to avoid low memory issues */
    - flags = current->flags & PF_MEMALLOC;
    - current->flags |= PF_MEMALLOC;
    - vaddr = (void *)get_zeroed_page(GFP_ATOMIC);
    - current->flags &= (~PF_MEMALLOC | flags);
    - return vaddr;
    + return (void *)get_zeroed_page(GFP_ATOMIC);
    }

    static inline void free_pgtable_page(void *vaddr)
    @@ -420,7 +398,7 @@ static inline void free_pgtable_page(void *vaddr)

    static inline void *alloc_domain_mem(void)
    {
    - return iommu_kmem_cache_alloc(iommu_domain_cache);
    + return kmem_cache_alloc(iommu_domain_cache, GFP_ATOMIC);
    }

    static void free_domain_mem(void *vaddr)
    @@ -430,7 +408,7 @@ static void free_domain_mem(void *vaddr)

    static inline void * alloc_devinfo_mem(void)
    {
    - return iommu_kmem_cache_alloc(iommu_devinfo_cache);
    + return kmem_cache_alloc(iommu_devinfo_cache, GFP_ATOMIC);
    }

    static inline void free_devinfo_mem(void *vaddr)
    @@ -440,7 +418,7 @@ static inline void free_devinfo_mem(void *vaddr)

    struct iova *alloc_iova_mem(void)
    {
    - return iommu_kmem_cache_alloc(iommu_iova_cache);
    + return kmem_cache_alloc(iommu_iova_cache, GFP_ATOMIC);
    }

    void free_iova_mem(struct iova *iova)
    --
    1.6.2.5




    \
     
     \ /
      Last update: 2009-11-17 08:23    [W:0.039 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site