lkml.org 
[lkml]   [2009]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 3/6] INIT: Limit the number of per cpu calibration bootup messages


    Ingo Molnar wrote:
    > * Mike Travis <travis@sgi.com> wrote:
    >
    >> --- linux.orig/init/calibrate.c
    >> +++ linux/init/calibrate.c
    >> @@ -123,23 +123,26 @@
    >> {
    >> unsigned long ticks, loopbit;
    >> int lps_precision = LPS_PREC;
    >> + bool boot_cpu = (smp_processor_id() == 0);
    >
    > this code is shared by other architectures too - are you sure
    > smp_processor_id()==0 is a proper 'I am the boot CPU' assumption
    > everywhere?
    >
    > Ingo

    This was where having the boot_cpu_id would have been handy.

    I could add something like:

    --- linux.orig/init/main.c
    +++ linux/init/main.c
    @@ -539,13 +539,15 @@
    * Activate the first processor.
    */

    +int boot_cpu_id __read_mostly;
    +
    static void __init boot_cpu_init(void)
    {
    - int cpu = smp_processor_id();
    + int boot_cpu_id = smp_processor_id();
    /* Mark the boot cpu "present", "online" etc for SMP and UP case */
    - set_cpu_online(cpu, true);
    - set_cpu_present(cpu, true);
    - set_cpu_possible(cpu, true);
    + set_cpu_online(boot_cpu_id, true);
    + set_cpu_present(boot_cpu_id, true);
    + set_cpu_possible(boot_cpu_id, true);
    }

    void __init __weak smp_setup_processor_id(void)
    and remove boot_cpu_id from arch/x86 ... ?

    Thanks,
    Mike


    \
     
     \ /
      Last update: 2009-11-16 22:49    [W:0.023 / U:206.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site