lkml.org 
[lkml]   [2009]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: fix wrong synaptics detection in psmouse_extensions()

[ fixed linux-input CC which I have typoed previously ]

On Mon, 16 Nov 2009, Dmitry Torokhov wrote:

> On Mon, Nov 16, 2009 at 12:51:30PM +0100, Jiri Kosina wrote:
> > Commit b7802c5c1ea ("Input: psmouse - use boolean type") caused the
> > synaptics_hardware variable to be completely useless, as it is constantly
> > set to 'true' throughout the whole psmouse_extensions(). This was caused
> > by the following hunk in the commit in question
> >
> > - int synaptics_hardware = 0;
> > + bool synaptics_hardware = true;
> >
> > which is wrong. Fix that up.
>
> Hmm, not sure what I was thinnking at that time but it is obviously I
> should have stayed away form tehe keyboard...
>
> Applied, thank you Jiri.

I guess you will be pushing that one to .32 still, right? I think it's
quite crucial fix, so if it doesn't make it in time for .32 (I am not sure
whether Linus will be doing next -rc or not), it should go to -stable for
.32 right away.

Thanks!

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2009-11-16 18:15    [W:0.049 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site