lkml.org 
[lkml]   [2009]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Add missing might_fault() from copy_{to,from}_user()
On Mon, Nov 16, 2009 at 04:09:37PM +0100, Ingo Molnar wrote:
>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > In x86-64, copy_to/from_user() rely on assembly routines that never
> > call might_fault(), making us missing various lockdep checks.
> >
> > This doesn't apply to __copy_from,to_user() that explicitly handle
> > these calls, neither is it a problem in x86-32 where
> > copy_to,from_user() rely on the "__" prefixed versions that also call
> > might_fault().
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > ---
> > arch/x86/include/asm/uaccess_64.h | 10 +++++++++-
> > arch/x86/lib/copy_user_64.S | 4 ++--
> > 2 files changed, 11 insertions(+), 3 deletions(-)
>
> Looks good - other than that you missed the renaming of the symbol
> export line in arch/x86/kernel/x8664_ksyms_64.c, which i fixed.



Oops, sorry!


> Thanks,
>
> Ingo



\
 
 \ /
  Last update: 2009-11-16 16:15    [W:0.041 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site