lkml.org 
[lkml]   [2009]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX -v3 for .32] crypto, gcm, fix another complete call in complete fuction
On Tue, Nov 10, 2009 at 03:39:11PM +0800, Huang Ying wrote:
> The flow of the complete function (xxx_done) in gcm.c is as follow:
>
> void complete(struct crypto_async_request *areq, int err)
> {
> struct aead_request *req = areq->data;
>
> if (!err) {
> err = async_next_step();
> if (err == -EINPROGRESS || err == -EBUSY)
> return;
> }
>
> complete_for_next_step(areq, err);
> }
>
> But *areq may be destroyed in async_next_step(), this makes
> complete_for_next_step() can not work properly. To fix this, one of
> following methods is used for each complete function.
>
> - Add a __complete() for each complete(), which accept struct
> aead_request *req instead of areq, so avoid using areq after it is
> destroyed.
>
> - Expand complete_for_next_step().
>
> The fixing method is based on the idea of Herbert Xu.
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>

Applied to crypto-2.6. Thanks a lot!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2009-11-16 14:55    [from the cache]
©2003-2011 Jasper Spaans