lkml.org 
[lkml]   [2009]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 05/12] vsprintf: reduce code size by avoiding extra check
    Date
    No functional change, just refactor the code so that it avoid checking
    "if (hi)" two times in a sequence, taking advantage of previous check made.

    It also reduces code size:
    text data bss dec hex filename
    15726 0 8 15734 3d76 vsprintf.o (ex lib/lib.a-BEFORE)
    15710 0 8 15718 3d66 vsprintf.o (ex lib/lib.a-AFTER)

    Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
    Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    lib/vsprintf.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    index d107583..3c83f7b 100644
    --- a/lib/vsprintf.c
    +++ b/lib/vsprintf.c
    @@ -745,8 +745,9 @@ static char *ip6_compressed_string(char *p, const char *addr)
    p = pack_hex_byte(p, hi);
    else
    *p++ = hex_asc_lo(hi);
    + p = pack_hex_byte(p, lo);
    }
    - if (hi || lo > 0x0f)
    + else if (lo > 0x0f)
    p = pack_hex_byte(p, lo);
    else
    *p++ = hex_asc_lo(lo);
    --
    1.6.5.2.180.gc5b3e.dirty
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-15 08:19    [W:0.024 / U:0.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site