Messages in this thread | | | From | André Goddard Rosa <> | Date | Sat, 14 Nov 2009 16:44:18 +0900 | Subject | Re: [ibm-acpi-devel] [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function |
| |
On Sat, Nov 14, 2009 at 1:20 PM, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote: > On Sat, 07 Nov 2009, André Goddard Rosa wrote: >> Also, while at it, if we see (*str && isspace(*str)), we can be sure to >> remove the first condition (*str) as the second one (isspace(*str)) also >> evaluates to 0 whenever *str == 0, making it redundant. In other words, >> "a char equals zero is never a space". > > You didn't document in isspace() that it must return false for NUL. Please > do that before you remove any such checks. >
Good idea Henrique, I will do it!
Thank you, André -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |