Messages in this thread | | | Date | Fri, 13 Nov 2009 23:48:20 +0100 | From | Ingo Molnar <> | Subject | Re: d451564 breakage |
| |
* Russell King <rmk@arm.linux.org.uk> wrote:
> Change: > > highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE > > Appears to break ARM: > > mm/highmem.c: In function ???debug_kmap_atomic???: > mm/highmem.c:436: error: ???KM_NMI??? undeclared (first use in this function)
indeed - sorry.
Note that debug_kmap_atomic() will be removed in v2.6.33 so i'd suggest to just do the easy solution and add #ifndef dummy definitions to mm/highmem.c to cover ARM - we'll remove the whole cruft for good.
Btw., testing sidenote: i test the ARM defconfig and it didnt break there. Perhaps highmem is off in the ARM defconfig? It would be helpful if the ARM defconfig enabled highmem.
Thanks,
Ingo
| |