Messages in this thread | | | Date | Fri, 13 Nov 2009 14:22:54 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] drivers/thermal/thermal_sys.c: fix strncmp tests |
| |
On Mon, 09 Nov 2009 14:12:49 -0800 Joe Perches <joe@perches.com> wrote:
> Use strncmp(var, "foo", sizeof("foo") - 1) > not strncmp(var, "foo", sizeof("foo")) > > Signed-off-by: Joe Perches <joe@perches.com> > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 4e83c29..c35d538 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -147,9 +147,9 @@ mode_store(struct device *dev, struct device_attribute *attr, > if (!tz->ops->set_mode) > return -EPERM; > > - if (!strncmp(buf, "enabled", sizeof("enabled"))) > + if (!strncmp(buf, "enabled", sizeof("enabled") - 1))
How about
if (!strcmp(buf, "enabled"))
?
| |