lkml.org 
[lkml]   [2009]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] pxa: make index mfp unsigned in mfp_read() and write()
    On Thu, Nov 12, 2009 at 12:05 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
    > When signed, it is possible in theory to pass a negative mfp,
    > and read/write outside the array bounds.
    >
    > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    > ---
    >  arch/arm/plat-pxa/include/plat/mfp.h |    4 ++--
    >  arch/arm/plat-pxa/mfp.c              |    4 ++--
    >  2 files changed, 4 insertions(+), 4 deletions(-)
    >
    > I did not observe the passing of a negative mfp anywhere so this
    > can be considered as a cleanup. Alternatively I could introduce
    > a `mfp < 0' check in mfp_{read,write} instead if desired.
    >

    I'd prefer to have a check in mfp_{read,write} instead.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-13 08:07    [W:0.021 / U:32.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site