lkml.org 
[lkml]   [2009]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] percpu fixes for 2.6.32-rc6

* Tejun Heo <tj@kernel.org> wrote:

> Hmmm... The thing is that the nesting isn't that deep there and
> breaking string in the middle is something we do quite often. What
> checkpatch warning did you see?

( i did not run checkpatch over your commit - i just assumed that the
ugliness was a checkpatch artifact. )

Breaking strings mid-sentence is something we try not to do. (If you
know about places that do it 'quite often' then those places need fixing
too.)

The biggest problem with it s that it breaks git grep. If someone sees
this message in the log:

PERCPU: allocation failed, size=1024 align=32, failed to extend area map of reserved chunk

and types the obvious:

git grep 'failed to extend area map of reserved chunk'

the git-grep comes up empty because the string was needlessly broken in
mid-sentence. Which is a confusing result and which causes people to
waste time trying to figure out where the message came from.

The other messages in this function are fine btw, for example:

git grep 'failed to populate'

will come up with the right place.

( There are also other reasons why we dont break strings mid-sentence -
it's also less readable to have it on two lines. )

Ingo


\
 
 \ /
  Last update: 2009-11-12 11:39    [W:0.144 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site