lkml.org 
[lkml]   [2009]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp
    From: Julia Lawall <julia@diku.dk>

    As an identical match is wanted in this case, strcmp can be used instead.

    The semantic match that lead to detecting this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression foo;
    constant char *abc;
    @@

    *strncmp(foo, abc, sizeof(abc))
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    fs/qnx4/inode.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c
    index 449f5a6..150f4af 100644
    --- a/fs/qnx4/inode.c
    +++ b/fs/qnx4/inode.c
    @@ -221,7 +221,8 @@ static const char *qnx4_checkroot(struct super_block *sb)
    rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE);
    if (rootdir->di_fname != NULL) {
    QNX4DEBUG((KERN_INFO "rootdir entry found : [%s]\n", rootdir->di_fname));
    - if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) {
    + if (!strcmp(rootdir->di_fname,
    + QNX4_BMNAME)) {
    found = 1;
    qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL );
    if (!qnx4_sb(sb)->BitMap) {

    \
     
     \ /
      Last update: 2009-11-12 11:17    [W:0.030 / U:34.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site