Messages in this thread | | | Date | Thu, 12 Nov 2009 13:19:06 -0800 | From | Mike Travis <> | Subject | Re: [PATCH 2/7] ACPI: Limit the number of per cpu ACPI bootup messages |
| |
David Rientjes wrote: > On Thu, 12 Nov 2009, Mike Travis wrote: > >> Limit the number of per cpu ACPI messages when system is booting to >> prevent clogging up the console output with repetitious messages. >> > > ... "by changing the log level from KERN_INFO to KERN_DEBUG." > >> Signed-off-by: Mike Travis <travis@sgi.com> >> --- >> drivers/acpi/fan.c | 2 +- >> drivers/acpi/processor_core.c | 2 +- >> drivers/acpi/tables.c | 28 +++++++++++++++++++--------- >> 3 files changed, 21 insertions(+), 11 deletions(-) >> >> --- linux.orig/drivers/acpi/fan.c >> +++ linux/drivers/acpi/fan.c >> @@ -267,7 +267,7 @@ >> goto end; >> } >> >> - dev_info(&device->dev, "registered as cooling_device%d\n", cdev->id); >> + dev_dbg(&device->dev, "registered as cooling_device%d\n", cdev->id); >> >> device->driver_data = cdev; >> result = sysfs_create_link(&device->dev.kobj, >> --- linux.orig/drivers/acpi/processor_core.c >> +++ linux/drivers/acpi/processor_core.c >> @@ -845,7 +845,7 @@ >> goto err_power_exit; >> } >> >> - dev_info(&device->dev, "registered as cooling_device%d\n", >> + dev_dbg(&device->dev, "registered as cooling_device%d\n", >> pr->cdev->id); >> >> result = sysfs_create_link(&device->dev.kobj, >> --- linux.orig/drivers/acpi/tables.c >> +++ linux/drivers/acpi/tables.c >> @@ -66,11 +66,15 @@ >> { >> struct acpi_madt_local_x2apic *p = >> (struct acpi_madt_local_x2apic *)header; >> - printk(KERN_INFO PREFIX >> - "X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", >> - p->local_apic_id, p->uid, >> - (p->lapic_flags & ACPI_MADT_ENABLED) ? >> - "enabled" : "disabled"); >> + /* >> + * Per cpu tracing clogs console output when NR_CPUS >> + * is large. Send only to kernel log buffer. >> + */ >> + printk(KERN_DEBUG PREFIX >> + "X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", >> + p->local_apic_id, p->uid, >> + (p->lapic_flags & ACPI_MADT_ENABLED) ? >> + "enabled" : "disabled"); >> } >> break; >> > > You can still use dev_dbg(PREFIX "...") here.
I thought dev_dbg needed the 'dev' structure and I wasn't sure how to get that...?
> >> @@ -171,10 +175,16 @@ >> { >> struct acpi_madt_local_sapic *p = >> (struct acpi_madt_local_sapic *)header; >> - printk(KERN_INFO PREFIX >> - "LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n", >> - p->processor_id, p->id, p->eid, >> - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); >> + /* >> + * Per cpu tracing clogs console output when NR_CPUS >> + * is large. Send only to kernel log buffer. >> + */ >> + printk(KERN_DEBUG PREFIX >> + "LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] " >> + "lsapic_eid[0x%02x] %s)\n", >> + p->processor_id, p->id, p->eid, >> + (p->lapic_flags & ACPI_MADT_ENABLED) ? >> + "enabled" : "disabled"); >> } >> break; >> > > Likewise, but recent emails from Linus indicate that we don't want to > break printk strings into multiple lines even if it goes over 80 > characters unless broken at '\n'. Users who grep for > "lsapic_id.*lsapic_eid" with this patch wouldn't find the string.
Ahh, ok, I hadn't heard that yet. (Grep just needs to be made smarter... ;-)
Thanks, Mike
| |