[lkml]   [2009]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] pxa: make index mfp unsigned in mfp_read() and write()
    When signed, it is possible in theory to pass a negative mfp,
    and read/write outside the array bounds.

    Signed-off-by: Roel Kluin <>
    arch/arm/plat-pxa/include/plat/mfp.h | 4 ++--
    arch/arm/plat-pxa/mfp.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    I did not observe the passing of a negative mfp anywhere so this
    can be considered as a cleanup. Alternatively I could introduce
    a `mfp < 0' check in mfp_{read,write} instead if desired.

    diff --git a/arch/arm/plat-pxa/include/plat/mfp.h b/arch/arm/plat-pxa/include/plat/mfp.h
    index 22086e6..0743f4a 100644
    --- a/arch/arm/plat-pxa/include/plat/mfp.h
    +++ b/arch/arm/plat-pxa/include/plat/mfp.h
    @@ -458,8 +458,8 @@ void __init mfp_init_addr(struct mfp_addr_map *map);
    * mfp_config_lpm() - configuring all low power MFPR registers for suspend
    * mfp_config_run() - configuring all run time MFPR registers after resume
    -unsigned long mfp_read(int mfp);
    -void mfp_write(int mfp, unsigned long mfpr_val);
    +unsigned long mfp_read(unsigned mfp);
    +void mfp_write(unsigned mfp, unsigned long mfpr_val);
    void mfp_config(unsigned long *mfp_cfgs, int num);
    void mfp_config_run(void);
    void mfp_config_lpm(void);
    diff --git a/arch/arm/plat-pxa/mfp.c b/arch/arm/plat-pxa/mfp.c
    index 9405d03..c80d0db 100644
    --- a/arch/arm/plat-pxa/mfp.c
    +++ b/arch/arm/plat-pxa/mfp.c
    @@ -203,7 +203,7 @@ void mfp_config(unsigned long *mfp_cfgs, int num)
    spin_unlock_irqrestore(&mfp_spin_lock, flags);

    -unsigned long mfp_read(int mfp)
    +unsigned long mfp_read(unsigned mfp)
    unsigned long val, flags;

    @@ -216,7 +216,7 @@ unsigned long mfp_read(int mfp)
    return val;

    -void mfp_write(int mfp, unsigned long val)
    +void mfp_write(unsigned mfp, unsigned long val)
    unsigned long flags;

     \ /
      Last update: 2009-11-11 16:57    [W:0.020 / U:13.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site