Messages in this thread Patch in this message | | | Subject | [PATCH v3 3/5] mm: refactor unregister_cpu_under_node() | From | Alex Chiang <> | Date | Tue, 10 Nov 2009 15:36:54 -0700 |
| |
By returning early if the node is not online, we can unindent the interesting code by two levels.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com> ---
drivers/base/node.c | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c index ef7dd22..ffda067 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -243,12 +243,18 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid) int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) { - if (node_online(nid)) { - struct sys_device *obj = get_cpu_sysdev(cpu); - if (obj) - sysfs_remove_link(&node_devices[nid].sysdev.kobj, - kobject_name(&obj->kobj)); - } + struct sys_device *obj; + + if (!node_online(nid)) + return 0; + + obj = get_cpu_sysdev(cpu); + if (!obj) + return 0; + + sysfs_remove_link(&node_devices[nid].sysdev.kobj, + kobject_name(&obj->kobj)); + return 0; }
| |