lkml.org 
[lkml]   [2009]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 0/4] perf bench: Common option for specifying style formatting
    From
    From: Ingo Molnar <mingo@elte.hu>
    Subject: Re: [PATCH v2 0/4] perf bench: Common option for specifying style formatting
    Date: Tue, 10 Nov 2009 04:58:12 +0100

    > > bench subcommand of perf.
    > >
    > > Users of perf bench will be able to specify
    > > style formatting with this option in common way.
    > >
    > > Hitoshi Mitake (4):
    > > perf bench: Add stuffs to bench.h for unified output formatting
    > > perf bench: Modify builtin-bench.c for processing common options
    > > perf bench: Modified bench/bench-messaging.c to adopt unified output
    > > formatting
    > > perf bench: Modify builtin-pipe.c for processing common options
    > >
    > > tools/perf/bench/bench.h | 9 ++++
    > > tools/perf/bench/sched-messaging.c | 18 +++++---
    > > tools/perf/bench/sched-pipe.c | 22 ++++++----
    > > tools/perf/builtin-bench.c | 79 +++++++++++++++++++++++++++++------
    > > 4 files changed, 99 insertions(+), 29 deletions(-)
    >
    > Very nice, applied to tip:perf/bench, thanks!
    >
    > A (very) small detail about initializers in bench.h:
    >
    > - No need to break the line for function prototypes, they are more
    > readable in a single line. (even if checkpatch complains about it)
    >
    > - We try to align definitions / structure fields vertically, to make it
    > all a bit more readable.
    >
    > Something like the (untested) cleanup patch below. (Just put it into
    > your next batch of commits.)
    >
    > Thanks,
    >
    > Ingo
    >
    > ---
    > tools/perf/bench/bench.h | 16 +++++++---------
    > 1 file changed, 7 insertions(+), 9 deletions(-)
    >
    > Index: tip/tools/perf/bench/bench.h
    > ===================================================================
    > --- tip.orig/tools/perf/bench/bench.h
    > +++ tip/tools/perf/bench/bench.h
    > @@ -1,17 +1,15 @@
    > #ifndef BENCH_H
    > #define BENCH_H
    >
    > -extern int bench_sched_messaging(int argc, const char **argv,
    > - const char *prefix);
    > -extern int bench_sched_pipe(int argc, const char **argv,
    > - const char *prefix);
    > +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
    > +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
    >
    > -#define BENCH_FORMAT_DEFAULT_STR "default"
    > -#define BENCH_FORMAT_DEFAULT 0
    > -#define BENCH_FORMAT_SIMPLE_STR "simple"
    > -#define BENCH_FORMAT_SIMPLE 1
    > +#define BENCH_FORMAT_DEFAULT_STR "default"
    > +#define BENCH_FORMAT_DEFAULT 0
    > +#define BENCH_FORMAT_SIMPLE_STR "simple"
    > +#define BENCH_FORMAT_SIMPLE 1
    >
    > -#define BENCH_FORMAT_UNKNOWN -1
    > +#define BENCH_FORMAT_UNKNOWN -1
    >
    > extern int bench_format;
    >
    >

    Thanks for your merge!

    I tested your cleaning patch, and this has no problem.
    So I'll queue this with next patch series post.

    And I have a question.
    In tools/perf/command-list.txt, there is the word "mainporcelain".
    What does this mean?

    Of course I searched this word on my dictionary, but cannot got an answer.
    I'm preparing the initial document for perf-bench.
    Can I add perf-bench with mainporcelain to command-list.txt?



    \
     
     \ /
      Last update: 2009-11-10 08:53    [W:0.045 / U:3.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site