lkml.org 
[lkml]   [2009]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] percpu fixes for 2.6.32-rc6
Ingo Molnar wrote:
> * Tejun Heo <tj@kernel.org> wrote:
>
>> In this case, as the second function needs to release to free the old
>> map, the extra unlock/lock pair is actually necessary. Splitting into
>> two functions is fine but I think it would be better to fix it first
>> and then split them in following patches so that it can be bisected if
>> I screw up while splitting, right?
>
> i think Linus's point was that this hack was the last straw that broke
> the camel's back, and that we are better off with a clean solution
> straight away. If you send the clean approach i can help test it on a
> good number of boxes.

If you're talking about the locking itself, there really is no clean
solution at this point. Until vmalloc locking is updated, we'll have
to do locking impedance matching in percpu code. I'm still not quite
sure whether we really need to update vmalloc code to be irqsafe.

If you're talking about the three way return value, which I do agree
to be quite ugly, I think it will be a lot safer to have three patches
- one to fix the deadlock, another to fix the return value and the
final one to de-uglify the function, especially as we're pretty late
in the release cycle.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-11-10 20:53    [W:0.251 / U:0.408 seconds]
©2003-2014 Jasper Spaans. hosted at Digital Ocean