Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v2 | Date | Tue, 10 Nov 2009 16:39:02 +0900 (JST) |
| |
> > > + > > > + /* Check this allocation failure is caused by cpuset's wall function */ > > > + for_each_zone_zonelist_nodemask(zone, z, zonelist, > > > + high_zoneidx, nodemask) > > > + if (!cpuset_zone_allowed_softwall(zone, gfp_mask)) > > > return CONSTRAINT_CPUSET; > > > > If cpuset and MPOL_BIND are both used, Probably CONSTRAINT_MEMORY_POLICY is > > better choice. > > No. this memory allocation is failed by limitation of cpuset's alloc mask. > Not from mempolicy.
But CONSTRAINT_CPUSET doesn't help to free necessary node memory. It isn't your fault. original code is wrong too. but I hope we should fix it.
| |