Messages in this thread | | | Date | Tue, 10 Nov 2009 17:23:37 +0000 | From | Alan Cox <> | Subject | Re: + prctl-add-pr_set_proctitle_area-option.patch added to -mm tree |
| |
> Yes, we can't do access_process_vm() under ->mmap_sem, but we can add > the new helper, say, access_process_vm_locked(tsk, mm, ...) which does > the actual work. Then proc_pid_cmdline() can take mmap_sem for reading, > read arg_start/arg_end and call access_process_vm_locked().
It might not be a bad idea if whoever wrote it spent about 60 seconds thinking about maths overflow as well. I'm not sure some of the tools will react too well if end is before start.
| |