Messages in this thread | | | Date | Tue, 10 Nov 2009 23:43:06 +0900 (JST) | Subject | Re: [PATCH 0/3] perf bench: Clean and add document for perf-bench | From | Hitoshi Mitake <> |
| |
From: Ingo Molnar <mingo@elte.hu> Subject: Re: [PATCH 0/3] perf bench: Clean and add document for perf-bench Date: Tue, 10 Nov 2009 14:17:38 +0100
> Applied, thanks! > > Btw., a small detail i noticed when running the pipe benchmark: > > earth4:~/tip/tools/perf> ./perf bench sched pipe > (executing 1000000 pipe operations between two tasks) > > Total time:5.076 sec > 5.076232 usecs/op > 196996 ops/sec > > when i typed 'perf bench sched pipe' nothing happened for several > seconds. The command did not finish and no output was printed. > > This might surprise users - it's always good to print a single line that > we are processing a benchmark. Maybe this could be printed from the > generic subcommand, something like: > > running sched/pipe benchmark ... > > What do you think?
Yeah, I have to admit that. Current style, keeping user wait and print everything suddenly after finish, is not good. I'll fix it.
And I also want to fix
> Total time:5.076 sec > 5.076232 usecs/op > 196996 ops/sec
this style. This is too bad. So I'll imitate style of perf-stat for making this format better.
Hitoshi
| |