Messages in this thread | | | Date | Tue, 10 Nov 2009 14:17:38 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/3] perf bench: Clean and add document for perf-bench |
| |
* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> This patch series cleans bench/bench.h for readability and > adds new document describing perf-bench. > > Hitoshi Mitake (3): > perf bench: Clean bench/bench.h > perf bench: Add new document of perf-bench > perf bench: Modify command-list.txt for the entry of perf-bench > > tools/perf/Documentation/perf-bench.txt | 120 +++++++++++++++++++++++++++++++ > tools/perf/bench/bench.h | 16 ++--- > tools/perf/command-list.txt | 1 + > 3 files changed, 128 insertions(+), 9 deletions(-) > create mode 100644 tools/perf/Documentation/perf-bench.txt
Applied, thanks!
Btw., a small detail i noticed when running the pipe benchmark:
earth4:~/tip/tools/perf> ./perf bench sched pipe (executing 1000000 pipe operations between two tasks)
Total time:5.076 sec 5.076232 usecs/op 196996 ops/sec
when i typed 'perf bench sched pipe' nothing happened for several seconds. The command did not finish and no output was printed.
This might surprise users - it's always good to print a single line that we are processing a benchmark. Maybe this could be printed from the generic subcommand, something like:
running sched/pipe benchmark ...
What do you think?
Ingo
| |