lkml.org 
[lkml]   [2009]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESENT] [RTC] Add Freescale MC13783 RTC driver
On Tue, Nov 10, 2009 at 10:30:54AM +0100, Alessandro Zummo wrote:
> On Tue, 10 Nov 2009 09:32:47 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > + ret = mc13783_irq_request_nounmask(priv->mc13783, MC13783_IRQ_1HZ,
> > + mc13783_rtc_update_handler, DRIVER_NAME, priv);
> > + if (ret)
> > + goto err_update_irq_request;
> > +
> > + mc13783_unlock(priv->mc13783);
> > +
> > + priv->rtc = rtc_device_register(pdev->name,
> > + &pdev->dev, &mc13783_rtc_ops, THIS_MODULE);
> > +
>
> isn't better to enable irqs after registration.
IMHO it doesn't make a difference for the 1HZ irq, still more as it
remains masked. The reset irq should be requested before registration.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2009-11-10 12:13    [from the cache]
©2003-2011 Jasper Spaans