Messages in this thread | | | Date | Tue, 10 Nov 2009 06:17:34 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] kernel.h: Add printk_ratelimited and pr_<level>_rl |
| |
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 30 Oct 2009 16:21:47 -0700 > Joe Perches <joe@perches.com> wrote: > > > +#define pr_emerg_rl(fmt, ...) \ > > + printk_ratelimited(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_alert_rl(fmt, ...) \ > > + printk_ratelimited(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_crit_rl(fmt, ...) \ > > + printk_ratelimited(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_err_rl(fmt, ...) \ > > + printk_ratelimited(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_warning_rl(fmt, ...) \ > > + printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_notice_rl(fmt, ...) \ > > + printk_ratelimited(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_info_rl(fmt, ...) \ > > + printk_ratelimited(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > > Would prefer pr_emerg_ratelimited personally. It's longer, but one > doesn't ask "wtf does _rl" mean and it avoids having two identifiers > which refer to the same thing.
Yeah. It will be rarely used so that it wont ever really be 'obvious at a glance', even to folks well versed in kernel source code details.
Ingo
| |