lkml.org 
[lkml]   [2009]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: wpa2 hangs v2.6.32-rc5-402-gb6727b1. Revert 7d930bc33653d5592dc386a76a38f39c2e962344 fixed it.


    On Mon, 2 Nov 2009, Jeff Chua wrote:
    >
    > I don't know how to redirect the console dump to a file. So, attached is
    > what it displayed taken from a camera.

    That decodes to

    cfg80211_conn_work+89:

    3: 89 ef mov %ebp,%edi
    5: e8 6f be 41 e1 callq 0xffffffffe141be79
    a: 48 8b 43 20 mov 0x20(%rbx),%rax
    e: f6 40 48 01 testb $0x1,0x48(%rax)
    12: 74 5d je 0x71
    14: 83 bb 8c 00 00 00 01 cmpl $0x1,0x8c(%rbx)
    1b: 75 54 jne 0x71
    1d: 48 ?? 50 08 ??? 0x8(%rax) ???? uncertain instruction ????
    21:* 8b 02 mov (%rdx),%eax <-- trapping instruction
    23: 41 89 45 00 mov %eax,0x0(%r13)
    27: 66 8b 42 04 mov 0x4(%rdx),%ax
    2b: 66 41 89 45 04 mov %ax,0x4(%r13)
    30: e8 f5 ea ff ff callq 0xffffffffffffeb2a

    trace:
    __cfg80111_scan_done
    worker_thread

    which looks like it matches this code:

    movq %r14, %rdi # D.43604,
    call mutex_lock #
    movq 32(%rbx), %rax # <variable>.netdev, <variable>.netdev
    testb $1, 72(%rax) #, <variable>.state
    je .L215 #,
    cmpl $1, 140(%rbx) #, <variable>.sme_state
    jne .L215 #,
    movq 144(%rbx), %rax # <variable>.conn, <variable>.conn
    movq %rbx, %rdi # wdev,
    movq 8(%rax), %rax # <variable>.params.bssid, <variable>.params.bssid
    movl (%rax), %edx #* <variable>.params.bssid, tmp74
    movl %edx, 0(%r13) # tmp74, bssid
    movw 4(%rax), %ax #, tmp75
    movw %ax, 4(%r13) # tmp75, bssid
    call cfg80211_conn_do_work #

    ie it looks like 'conn->params.bssid' is NULL and we oops when we try to
    load bssid from there. The code is:

    memcpy(bssid, wdev->conn->params.bssid, ETH_ALEN);

    where ETH_ALEN is 6 bytes, so the memcpy is inlined..

    And yes, that "memcpy()" was added in that buggy commit.

    So reverting 7d930bc33653d5592dc386a76a38f39c2e962344 is the correct thing
    to do. Or somebody needs to fix that piece-of-shit code.

    Linus


    \
     
     \ /
      Last update: 2009-11-18 23:46    [W:0.022 / U:62.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site