Messages in this thread | | | Date | Fri, 09 Oct 2009 16:18:03 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH 2/4] mce-inject: use individual members instead of struct mce |
| |
Huang Ying wrote: > On Fri, 2009-10-09 at 13:45 +0800, Hidetoshi Seto wrote: >> struct mce have many members and almost half of them are not used >> for mce injection. So make struct mce_fake_banks to have required >> members instead of having struct mce in it. > > I don't think this is necessary. struct mce works fine.
Why do you think so? I think having unused space in precious per-CPU is not good idea.
And this change is required to reduces the size of allocation unit in later patch to support multiple error injection.
Thanks, H.Seto
| |