Messages in this thread | | | Date | Fri, 09 Oct 2009 16:11:28 +0900 | From | Kenji Kaneshige <> | Subject | Re: [PATCH] PCIe AER: honor ACPI HEST FIRMWARE FIRST mode |
| |
Matt Domsch wrote: > For review and comment. > > Today, the PCIe Advanced Error Reporting (AER) driver attaches itself > to every PCIe root port for which BIOS reports it should, via ACPI > _OSC. > > However, _OSC alone is insufficient for newer BIOSes. Part of ACPI > 4.0 is the new Platform Environment Control Interface (PECI), which is > a way for OS and BIOS to handshake over which errors for which > components each will handle. One table in ACPI 4.0 is the Hardware > Error Source Table (HEST), where BIOS can define that errors for > certain PCIe devices (or all devices), should be handled by BIOS > ("Firmware First mode"), rather than be handled by the OS. > > Dell PowerEdge 11G server BIOS defines Firmware First mode in HEST, so > that it may manage such errors, log them to the System Event Log, and > possibly take other actions. The aer driver should honor this, and > not attach itself to devices noted as such. > > > Signed-off-by: Matt Domsch <Matt_Domsch@dell.com> >
In the current AER driver implementation, correctable, non-fatal, fatal, unsupported request reporting enable bits in PCIe device control register can be changed by adapter card drivers through pci_enable_pcie_error_reporting() or pci_disable_pcie_error_reporting() APIs, regardless of _OSC evaluation result.
I'm not sure, but I guess you might need to prevent those bits from being changed in the Firmware First mode.
Thanks, Kenji Kaneshige
| |