Messages in this thread | | | Date | Fri, 9 Oct 2009 21:29:47 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] nvram: Drop the bkl from nvram_llseek() |
| |
On Fri, Oct 09, 2009 at 09:27:17PM +0200, Thomas Gleixner wrote: > B1;2005;0cOn Fri, 9 Oct 2009, Frederic Weisbecker wrote: > > > There is nothing to protect inside nvram_llseek(), the file > > offset doesn't need to be protected and nvram_len is only > > initialized from an __init path. > > > > It's safe to remove the big kernel lock there. > > > > (Is this file still used? I can't even build it, > > looks like it is built under CONFIG_GENERIC_NVRAM but this > > option is referenced nowhere except in powerpc defconfigs) > > Yes it is used. Look at arch/powerpc/Kconfig > > config GENERIC_NVRAM > bool > default y if PPC32
Oh right, I missed it.
> But I have to admit that the GENERIC part is confusing :)
Yep :)
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ingo Molnar <mingo@elte.hu> > > Cc: John Kacur <jkacur@redhat.com> > > Cc: Sven-Thorsten Dietrich <sven@thebigcorporation.com> > > Cc: Jonathan Corbet <corbet@lwn.net> > > Cc: Alessio Igor Bogani <abogani@texware.it> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Cc: Greg KH <gregkh@suse.de> > > Added to the pile of pending BKL bashing. Thanks, > > tglx
Ok. Be care I couldn't even build test this one.
Thanks.
| |