Messages in this thread | | | Date | Fri, 9 Oct 2009 06:55:11 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 2/2] kmemleak: Check for NULL pointer returned by create_object() |
| |
On Fri, Oct 09, 2009 at 10:30:34AM +0100, Catalin Marinas wrote: > This patch adds NULL pointer checking in the early_alloc() function.
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> > --- > mm/kmemleak.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index a617518..8bf765c 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -834,11 +834,14 @@ static void early_alloc(struct early_log *log) > rcu_read_lock(); > object = create_object((unsigned long)log->ptr, log->size, > log->min_count, GFP_ATOMIC); > + if (!object) > + goto out; > spin_lock_irqsave(&object->lock, flags); > for (i = 0; i < log->trace_len; i++) > object->trace[i] = log->trace[i]; > object->trace_len = log->trace_len; > spin_unlock_irqrestore(&object->lock, flags); > +out: > rcu_read_unlock(); > } > >
| |