Messages in this thread | | | Date | Fri, 09 Oct 2009 14:38:17 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH 6/6] mce-inject: use injected mce only during faked handler call |
| |
Huang Ying wrote: > On Mon, 2009-10-05 at 11:10 +0800, Hidetoshi Seto wrote: >> +/* >> + * For error injection >> + */ >> + >> +struct mce_fake_banks { >> + int valid; >> + struct mce injectm; >> +}; > > There are some bits available in mce.inject_flags. I don't think it is > necessary to add another variable just for another flag.
I disagreed. I think it is necessary.
If we try to support injecting multiple event to a cpu, we should have a flag like this sooner or later. Or we have to manage injectm[].inject_flags.
And I think the inject_flags should not have bits for kernel internal use. All bits in inject_flags should be used by tools to tell attributes of data injected with the flag.
As a sample I made an additional patch set to support injecting multiple event to a CPU. These change doesn't break current functionality. Some improve will be required on mce-inject tool to use this feature.
Check my patches and comment on it.
Thanks, H.Seto
| |