lkml.org 
[lkml]   [2009]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel/time/tick-sched.c: fix warning of printk's argument format
    On Thu, Oct 08, 2009 at 08:03:40AM -0700, Linus Torvalds wrote:

    > > This patch will fix the following warning:
    >
    > No it won't. It will add a lot of new warnings.
    >
    > The thing is, almost all architectures (including x86) have
    >
    > unsigned int __softirq_pending;
    >
    > but then in <asm-generic/hardirq.h> we have
    >
    > unsigned long __softirq_pending;
    >
    > for some unfathomable reason. Quite frankly, I think Arnd just screwed up
    > the "generic" version, and the fix is almost certainly to just make the
    > generic version match all the main architectures.
    >
    > I don't have any architectures using the generic header file, though, so
    > I'm not going to do that change blindly. People who do should look at it
    > (alpha, powerpc and mips look like the only ones that might be 64-bit, but
    > I didn't check very carefully - just grepped for it)
    >
    > Added Cc's for some people that have worked on, or used, that generic
    > header file. Is there any possible reason why it is "unsigned long" in
    > that one?

    I think for no other reason than many other bitfields in kernel being
    unsigned long or arrays of unsigned long. Except of course that
    __softirq_pending is never being used with the <asm/bitops.h> operations
    that operate on unsigned longs.

    Patch in followup email.

    Ralf


    \
     
     \ /
      Last update: 2009-10-09 12:33    [W:0.021 / U:0.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site