Messages in this thread | | | Date | Thu, 8 Oct 2009 22:19:01 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 4/5] usb_serial: Kill port mutex |
| |
On Thu, 8 Oct 2009 22:40:36 +0200 Oliver Neukum <oliver@neukum.org> wrote:
> Am Donnerstag, 8. Oktober 2009 22:06:10 schrieb Alan Stern: > > > > > On further thought, unthrottle should autoresume if the device is > > open and autosuspended (but it shouldn't do anything if the device is > > suspended). After all, the reason for the autosuspend may have been > > the lack of activity caused by the throttling. > > > > In practice this isn't likely to come up. It would be surprising if > > throttling lasted long enough to cause an autosuspend or if the core > > decided to throttle while the device was autosuspended and hence idle. > > So you say that throttle() should do an autopm_put?
You need to be very very sure you cannot lose a byte of data or have the modem lines disrupted in any way if you do that.
| |